Vishwanath BS <vishwanath.bs@xxxxxx> writes:
> Since IO Daisychain modifies only PRM registers, it makes sense to move it to
> PRM File.
You also rename the function but don't describe why or what the new name
means or where it comes from. An only the 'enable' version is renamed,
but the 'disable' version stays the same. Confusing.
Also, please fix checkpatch warning:
WARNING: line over 80 characters
#103: FILE: arch/arm/mach-omap2/prm2xxx_3xxx.c:259:
+ omap2_prm_clear_mod_reg_bits(OMAP3430_EN_IO_CHAIN_MASK, WKUP_MOD,
[...]
> +/* OMAP3 Daisychain trigger sequence */
> +void omap3_trigger_wuclk_ctrl(void)
> +{
> + int i = 0;
> +
> + omap2_prm_set_mod_reg_bits(OMAP3430_EN_IO_CHAIN_MASK, WKUP_MOD,
> + PM_WKEN);
> + /* Do a readback to assure write has been done */
> + omap2_prm_read_mod_reg(WKUP_MOD, PM_WKEN);
> +
> + omap_test_timeout(
> + (((omap2_prm_read_mod_reg(WKUP_MOD, PM_WKST) &
> + OMAP3430_ST_IO_CHAIN_MASK) == 1)),
> + MAX_IOPAD_LATCH_TIME, i);
indentation is messy
> +
> + omap2_prm_clear_mod_reg_bits(OMAP3430_EN_IO_CHAIN_MASK, WKUP_MOD,
> + PM_WKEN);
> +}
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
