Hi Vaibhav, On Mon, Jan 2, 2012 at 2:55 PM, Bedia, Vaibhav <vaibhav.bedia@xxxxxx> wrote: > Hello, > > On Fri, Nov 11, 2011 at 15:31:52, R, Govindraj wrote: > [...] >> >> - if ((cpu_is_omap34xx() || cpu_is_omap44xx()) && bdata->pads) >> + if (((cpu_is_omap34xx() || cpu_is_omap44xx()) && bdata->pads) >> + && !uart_debug) >> device_init_wakeup(&pdev->dev, true); >> } > > I was testing this on AM335x and realized that this leads to creation of two > 'wakeup' entries for UART. One is created by the tty layer in serial-core.c > and the other is created here. > > Here's what I see on a branch based on Tony's 3.2-rc6: > > ./sys/devices/platform/omap/omap_uart.0/power/wakeup > ./sys/devices/platform/omap/omap_uart.0/tty/ttyO0/power/wakeup > > Shouldn't the OMAP serial just enable the 'wakeup' entry created by serial-core.c? currently runtime pm is available from omap-serial device and not from tty_dev. Setting tty_dev wakeup is to use irq_wakeup from suspend available from serail_core layer which I think we are not using for omap-uart and we use pad wakeup from suspend path. Also omap-uart.x/power/wakeup is used to gate uart clocks using runtime PM api's in omap-serial driver. -- Thanks, Govindraj.R -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
