Hi Ilya,
On 12/20/11 22:07, Ilya Yanok wrote:
> Hi Igor,
>
>>> +static struct omap2_hsmmc_info mmc[] = {
>>> + {
>>> + .mmc = 1,
>>> + .caps = MMC_CAP_4_BIT_DATA,
>>> + .gpio_cd = SD_CARD_CD,
>>> + .gpio_wp = SD_CARD_WP,
>>> + .ocr_mask = MMC_VDD_32_33 | MMC_VDD_33_34 |
>>> + MMC_VDD_165_195,
>>
>> The ocr_mask will be overridden, by the following patch:
>> -----------------
>> commit e89715a7e48d505f42813a4e3ee0f0efb49832ba
>> Author: Abhilash K V <abhilash.kv@xxxxxx>
>> Date: Fri Dec 9 12:27:36 2011 -0800
>>
>> ARM: OMAP: hsmmc: Support for AM3517 MMC1 voltages
>> --------------
>>
>> in Tony's hsmmc branch.
>>
>> IMO it should be fixed, by adding a check if the ocr_mask is
>> already set...
>> I can't send a patch for this right now...
>
> Well, I think I should just drop the .ocr_mask field then. Everything
> works fine for me with the above mentioned patch.
Yes, for your patch, it is correct - just remove it.
My concern is for the common code - it will override any
board special setting (e.g. you want smaller range supported).
>>> +static void __init mcx_init(void)
>>> +{
>>> + int err;
>>> +
>>> + omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
>>> + mcx_i2c_init();
>>> + platform_add_devices(mcx_devices, ARRAY_SIZE(mcx_devices));
>>> + omap_serial_init();
>>
>> Shouldn't this one be before the mcx_i2c_init() call?
>
> Well, I think I've taken this order from some other board init... I
> think the idea was to bring up regulator chip earlier. But I can move
> serial up with no problem.
I see, no problem.
My "concern" was about the pr_err() inside the mcx_i2c_init()
and the mcx_ts_init() functions.
Also, IMO, mcx_ts_init() can be done at a later stage, than along
with I2C buses initialization, but it does not really meter...
--
Regards,
Igor.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
