Hi,
On 21.12.2011 10:07, Hiremath, Vaibhav wrote:
>> +static struct resource am35xx_mdio_resources[] = {
>> + {
>> + .start = AM35XX_IPSS_EMAC_BASE + AM35XX_EMAC_MDIO_OFFSET,
>> + .end = AM35XX_IPSS_EMAC_BASE + AM35XX_EMAC_MDIO_OFFSET +
>> + SZ_4K - 1,
>> + .flags = IORESOURCE_MEM,
>> + },
>> +};
> This will not be board independent, using AM35xx everywhere.
Why? It will work for any AM35XX based board. Probably we can try and
make it work with EMACs on other AM3XXXs but I don't have these devices.
> To make it completely board independent, you should get all this platform
> specific data from board file. Probably have emac_init() function here and
> pass the data.
Hm.. This data is SoC-dependent not board-dependent, what's the reason
to move it to the board file?
> Do you know any other platform or device using this IP?
Yes, I have a couple of AM3517 based boards that use this IP.
Regards, Ilya.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
