On Wed, Dec 14, 2011 at 8:59 PM, Kevin Hilman <khilman@xxxxxx> wrote: > Govindraj <govindraj.ti@xxxxxxxxx> writes: > >> On Wed, Dec 14, 2011 at 12:56 AM, Kevin Hilman <khilman@xxxxxx> wrote: >>> Govindraj <govindraj.ti@xxxxxxxxx> writes: >>> >>> [...] >>> >>>> I have re-based this patch series against LO master >>>> commit id: deee6d5359969a0ce4e2760cfd7b9f379bd5698a >>>> >>>> Same is available here [1] >>>> >>>> I have tested this patch series along with: >>>> >>>> 1.) Tero's V11 irq chaining series >>>> http://www.spinics.net/lists/linux-omap/msg61445.html >>>> (This patch series is used for uart wakeup handling using >>>> prcm_irq chaining) >>>> >>>> 2.) Rajendra's hwmod change >>>> http://www.spinics.net/lists/arm-kernel/msg148632.html >>>> (This patch handles init_no_idle flag setting >>>> without this patch there will be boot warning however >>>> all pm features will work after boot up.) >>>> >>>> 3.) Vishwa's io daisy chain changes. >>>> http://permalink.gmane.org/gmane.linux.ports.arm.omap/65500 >>>> (tested with and without this patch series pm features works). >>>> >>>> Same combination of patches based on above commit id >>>> used for testing is available here [2]. >>> >>> Please have a closer look at your branch. >>> >>> The second commit[1] commits the .rej file from a failed patch apply, >>> so obviously doesn't do what was intended. >>> >> >> Sorry my bad I have refreshed the uart runtime branch [1] >> & test branch [2]. > > Can you add another patch which fixes these compiler warnings: > > /work/kernel/omap/pm/drivers/tty/serial/omap-serial.c: In function 'serial_omap_irq': > /work/kernel/omap/pm/drivers/tty/serial/omap-serial.c:228:29: warning: 'ch' may be used uninitialized in this function [-Wuninitialized] > /work/kernel/omap/pm/drivers/tty/serial/omap-serial.c:176:16: note: 'ch' was declared here > /work/kernel/omap/pm/drivers/tty/serial/omap-serial.c:228:29: warning: 'ch' may be used uninitialized in this function [-Wuninitialized] > /work/kernel/omap/pm/drivers/tty/serial/omap-serial.c:176:16: note: 'ch' was declared here > Here is the patch [1] and pushed to git://gitorious.org/runtime_3-0/runtime_3-0.git for_3_3/lo_rc4_uartruntime -- Thanks, Govindraj.R [1]: >From 3a40f4e1a4c6db40d06cc6c5536ec06e9e5daf3d Mon Sep 17 00:00:00 2001 From: "Govindraj.R" <govindraj.raja@xxxxxx> Date: Wed, 14 Dec 2011 21:24:11 +0530 Subject: [PATCH] OMAP2+: UART: Fix compilation/sparse warnings Fixes below compilation warning. drivers/tty/serial/omap-serial.c: In function 'serial_omap_irq': drivers/tty/serial/omap-serial.c:228:29: warning: 'ch' may be used uninitialized in this function [-Wuninitialized] Fix below sparse warning. drivers/tty/serial/omap-serial.c:392:52: warning: incorrect type in argument 2 (different signedness) drivers/tty/serial/omap-serial.c:392:52: expected int *status drivers/tty/serial/omap-serial.c:392:52: got unsigned int *<noident> Reported-by: Kevin Hilman <khilman@xxxxxx> Signed-off-by: Govindraj.R <govindraj.raja@xxxxxx> --- drivers/tty/serial/omap-serial.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index f3ff0ca..7b0303d 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -166,11 +166,12 @@ static void serial_omap_stop_rx(struct uart_port *port) pm_runtime_put_autosuspend(&up->pdev->dev); } -static inline void receive_chars(struct uart_omap_port *up, int *status) +static inline void receive_chars(struct uart_omap_port *up, + unsigned int *status) { struct tty_struct *tty = up->port.state->port.tty; - unsigned int flag; - unsigned char ch, lsr = *status; + unsigned int flag, lsr = *status; + unsigned char ch = 0; int max_count = 256; do { -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
