"Cousson, Benoit" <b-cousson@xxxxxx> writes: > On 9/17/2011 6:13 PM, Grant Likely wrote: >> On Fri, Sep 16, 2011 at 04:43:19PM +0200, Benoit Cousson wrote: [...] >>> +} >>> + >>> +static int _omap_device_notifier_call(struct notifier_block *nb, >>> + unsigned long event, void *dev) >> >> Nit: Why the preceding underscore? Generally that is only done for >> 'special' variants of public functions. ie. for a variant that >> expects a lock to already be held. > > Yeah, the convention in this file is not that strict, and it is used > for internal static helper function as well. > I'll let Kevin arbitrate that point :-) The convention in this file is the leading '_' is used for internal helper functions. I'd prefer to keep it that way, and if we decide to change the coding convention to match a coding convention elsewhere, we should do it all at the same time. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
