On Friday 16 September 2011 09:10 PM, Cousson, Benoit wrote: > Hi Sricharan, > > On 9/9/2011 6:02 PM, R, Sricharan wrote: >> The address spaces, irqs and dma reqs count API returns the >> number of corresponding entries in a hwmod including a additional >> null value or a -1 terminator in the structure introduced >> recently. More information here: >> >> 212738a4 (omap_hwmod: use a terminator record with >> omap_hwmod_mpu_irqs arrays) >> 78183f3f (omap_hwmod: use a null structure record to terminate >> omap_hwmod_addr_space arrays) >> bc614958 (omap_hwmod: use a terminator record with >> omap_hwmod_dma_info arrays) >> >> The devices which have multiple hwmods and use device_build_ss are >> broken with this, as their resources are populated with a >> extra null value, subsequently the probe fails. So fix the API not to >> include the array terminator in the count. >> >> Signed-off-by: sricharan<r.sricharan@xxxxxx> >> Signed-off-by: Santosh Shilimkar<santosh.shilimkar@xxxxxx> >> Cc: Benoit Cousson<b-cousson@xxxxxx> >> Cc: Paul Walmsley<paul@xxxxxxxxx> >> Cc: Kevin Hilman<khilman@xxxxxx> > > It would have been nice to give me the credit for the bug report on the > other functions, but otherwise: > Sure. Will add reported-by of yours. > Acked-by: Benoit Cousson <b-cousson@xxxxxx> > Thanks > And I still prefer the return i - 1 :-) > Let's do "i-1" as you prefer. Maintainer always have final say !! Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
