On Friday 16 September 2011 11:21 PM, Kevin Hilman wrote: > Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes: > >> CPU local timer(TWD) stops when the CPU is transitioning into >> deeper C-States. Since these timers are not wakeup capable, we >> need the wakeup capable global timer to program the wakeup time >> depending on the next timer expiry. >> >> It can be handled by registering a global wakeup capable timer along >> with local timers marked with (mis)feature flag CLOCK_EVT_FEAT_C3STOP. > > nit: this comment makes is sound like this patch adds the registration > of this timer, when all this patch does is add the notification. > > Changelog should be updated to make it clear that the global timer exists > already, and is already marked with the C3STOP flag. > Will add couple of lines in the change log to make it clear. >> Then notify the clock events layer from idle code using >> CLOCK_EVT_NOTIFY_BROADCAST_ENTER/EXIT). >> >> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> >> Cc: Kevin Hilman <khilman@xxxxxx> > > Other than that > > Acked-by: Kevin Hilman <khilman@xxxxxx> > Thanks. Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
