Hi, On Tue, Sep 6, 2011 at 3:09 PM, K, Mythri P <mythripk@xxxxxx> wrote: > Hi, > > On Mon, Sep 5, 2011 at 6:52 PM, K, Mythri P <mythripk@xxxxxx> wrote: >> Hi, >> >> On Mon, Sep 5, 2011 at 5:45 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: >>> On Fri, 2011-09-02 at 16:17 +0530, mythripk@xxxxxx wrote: >>>> From: Mythri P K <mythripk@xxxxxx> >>>> >>>> HDMI IP block is common between TI OMAP4 Procerssor and Netra processor although >>>> the Display subsytem is different.Also the IP block in future OMAP may differ >>>> from the one existing in OMAP4. Thus to reuse the code between these two >>>> processors , and maintain the multi omap build functionality in DSS. >>>> HDMI IP dependant code is seperated out from hdmi.c and moved to >>>> new library file hdmi_ti_4xxx_ip.c.From the DSS dependent HDMI code only the >>>> function pointer to functionality/features offered by HDMI is called. >>>> >>>> This patch series does the split and also renames hdmi_omap4_panel.c to >>>> hdmi_panel.c as that file has nothing specific to OMAP4 and can be reused for >>>> other OMAP family of processors as well. >>>> >>>> This patch series is based on Tomi's LO-DSS2 master branch. >>> >>> The kernel doesn't compile at all after enabling >>> SND_OMAP_SOC_OMAP4_HDMI. Looks like you didn't move any of the sound >>> stuff, but just left them in hdmi.c file. >>> >> I shall check this, may be i should handle some dependency but i didnt >> think there were any direct dependency , i guess you need to enable >> some audio files as well? let me check. > > There is a dependency on the audio files on the register writers and i > was not very sure on what would be a genuine API v's what can be a > static function. > Ricardo any comments would you like to post a patch on top of this series ? > I have made a temporary patch to move the IP dependent audio functions to ti_hdmi_4xxx_ip.c and i see it compiles fine, later on we can decide on what could be the API's and move the audio(non IP dependent ) portion out of DSS ? are you ok with that ? Thanks and regards, Mythri. > thanks and regards, > Mythri. >>> Tomi >>> >>> >>> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
