Hi, On Tue, Sep 6, 2011 at 3:47 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > On Tue, 2011-09-06 at 11:38 +0530, K, Mythri P wrote: >> >> Did you consider how the code would look if the function pointers >> were >> >> just included into struct hdmi_ip_data, without any ops struct at >> all? >> >> >> I tried without ops structure , but then using it in dss_features to >> initialize would be a problem so i have moved it to ti_hdmi.h. > > I'm fine with the ops struct, but I don't see why it would be a problem > without it. You'd just pass the hdmi_ip_data to dss_features, which > would initialize it. well instead of passing the struct ops if the function pointers are included in ip_data directly, in dss_features each function will have to be initialized in the dss_init_hdmi_ip_ops function i thought it is cleaner to initialize the struct :-) ,it just looked cleaner to me :-). else the entire intialization will come in a if else condition for CPU's. Thanks and regards, Mythri. > > Tomi > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
