Vishwanath Sripathy <vishwanath.bs@xxxxxx> writes: [...] >> >> diff --git a/arch/arm/mach-omap2/opp3xxx_data.c b/arch/arm/mach- >> omap2/opp3xxx_data.c >> >> index d95f3f9..b5d8294 100644 >> >> --- a/arch/arm/mach-omap2/opp3xxx_data.c >> >> +++ b/arch/arm/mach-omap2/opp3xxx_data.c >> >> @@ -26,6 +26,16 @@ >> >> #include "pm.h" >> >> >> >> /* 34xx */ >> >> +/* OMAP VP parameter values */ >> >> +#define OMAP3430_VP1_VLIMITTO_VDDMIN 0x14 >> >> +#define OMAP3430_VP1_VLIMITTO_VDDMAX 0x42 >> >> +#define OMAP3430_VP2_VLIMITTO_VDDMIN 0x18 >> >> +#define OMAP3430_VP2_VLIMITTO_VDDMAX 0x2c >>> NAK -> we should be using voltages here -> depending on the PMIC >>> used, the rounding factor may not map to TWL4030. >> >> Agreed. >> >> > I had posted patch for this earlier I believe in series >> > http://marc.info/?l=linux-omap&m=130741297821372&w=2 >> >> I know you're a bit distracted currently ;) but is there any chance >> you can refresh at least this patch: >> >> OMAP3+: PM: VP: use uV for max and min voltage limits >> >> from your series on top of my current pm-wip/voltdm branch? >> >> If not, maybe point us to an archived version and Tero can pick it up >> and add it to this series. After a quick search, I couldn't find it >> in the marc.info archives. > > Below link should help I suppose. > https://patchwork.kernel.org/patch/855172/ > Yes, Tero should pick this one up and add it to his series to address Nishanth's concerns. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html