Hi Nishanth, "Menon, Nishanth" <nm@xxxxxx> writes: > here is my quick feedback: > > > On Wed, Aug 3, 2011 at 10:29, Tero Kristo <t-kristo@xxxxxx> wrote: >> >> This patch separates board specific voltage and oscillator ramp / setup >> times from the core code. Things changed: >> >> - on/sleep/ret/off voltage setup moved from common twl code to >> VC / VP data (oppxxxx_data.c files) >> - added board support for vdd ramp up / down times >> - added board support for oscillator setup time declaration >> >> Todo: split patch into more easily manageable parts. >> >> Applies on top of pm/wip/voltdm branch, based on work done by Vishwanath >> Sripathy. >> >> Signed-off-by: Tero Kristo <t-kristo@xxxxxx> >> Cc: Vishwanath Sripathy <vishwanath.bs@xxxxxx> [...] >> diff --git a/arch/arm/mach-omap2/opp3xxx_data.c b/arch/arm/mach-omap2/opp3xxx_data.c >> index d95f3f9..b5d8294 100644 >> --- a/arch/arm/mach-omap2/opp3xxx_data.c >> +++ b/arch/arm/mach-omap2/opp3xxx_data.c >> @@ -26,6 +26,16 @@ >> #include "pm.h" >> >> /* 34xx */ >> +/* OMAP VP parameter values */ >> +#define OMAP3430_VP1_VLIMITTO_VDDMIN 0x14 >> +#define OMAP3430_VP1_VLIMITTO_VDDMAX 0x42 >> +#define OMAP3430_VP2_VLIMITTO_VDDMIN 0x18 >> +#define OMAP3430_VP2_VLIMITTO_VDDMAX 0x2c > NAK -> we should be using voltages here -> depending on the PMIC used, > the rounding factor may not map to TWL4030. Agreed. > I had posted patch for this earlier I believe in series > http://marc.info/?l=linux-omap&m=130741297821372&w=2 I know you're a bit distracted currently ;) but is there any chance you can refresh at least this patch: OMAP3+: PM: VP: use uV for max and min voltage limits from your series on top of my current pm-wip/voltdm branch? If not, maybe point us to an archived version and Tero can pick it up and add it to this series. After a quick search, I couldn't find it in the marc.info archives. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
