On 06/07/11 04:54 AM, Premi, Sanjeev wrote: >> -----Original Message----- >> From: linux-omap-owner@xxxxxxxxxxxxxxx >> [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Tony Lindgren >> Sent: Wednesday, July 06, 2011 12:26 PM >> To: Raphaël Assénat; Paul Walmsley >> Cc: linux-omap@xxxxxxxxxxxxxxx >> Subject: Re: AM3505/3517 support >> >> * Raphaël Assénat <raph@xxxxxx> [110705 07:30]: >>> On 05/07/11 07:19 AM, Tony Lindgren wrote: >>>> * Raphaël Assénat <raph@xxxxxx> [110704 12:51]: >>>>> >>>>> The am3505 is apparently so similar to the 3430 that it >> was treated as such >>>>> (omap_chip.oc was being set to CHIP_IS_OMAP3430ES3_1). >> There are however a >>>>> few differences that need to be addressed. I have >> therefore created a new >>>>> CHIP_IS and patched clocks, hwmod and power management >> related files >>>>> consequently. My system now boots until it complains >> that it is unable >>>>> to mount its root filesystem. >>>> >>>> Can you please describe where you need CHIP_IS for >> am3505? It seems that >>>> your patches just enable the same CHIP_IS_OMAP3430 >> features for am3505 too? >>> >>> Actually it's only needed for the 3505/3517 specific UART 4 >> which should >>> not be registered on real OMAP3430's. (see struct omap_hwmod >>> am35xx_uart4_hwmod; in omap_hwmod_3xxx_data.c) >>> >>> But there are also cases where OMAP3430 hwmods must not be >> registered >>> on AM35xx. For instance, omap3xxx_timer12_hwmod since timer12 does >>> not exist general purpose AM3505's. >> >> Sounds like we should be able to handle both uart and >> gptimer12 the same way >> as we'll be handling the hwmod reset for special cases like >> gptimer12 for >> secure mode. So addding Paul to Cc. >> >> Basically we can have a am35xx specific arch_initcall that >> sets the special >> flags for these devices like noreset, disabled or unavailable. >> >> In this case we would just set some devices as unavailable on am35xx. > > [sp] AM35x is already supported in the kernel. Specifically for the > changes being discussed, see this commit: > > commit 3cc4a2fc2ed7727828f410ab092111cb56cefd61 > Author: Ranjith Lohithakshan <ranjithl@xxxxxx> > Date: Wed Feb 24 12:05:55 2010 -0700 > > AM35xx: Add clock support for new modules on AM35xx > > I believe this patch already contains most AM35xx specific changes > related to clocks. Indeed, most of these changes are present in the current kernel. But right now, it does not work as-is. Only a few things are missing and that's what I'm trying to address. I'll try Tony's suggestion. It should yield a much smaller patch. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
