Hi Mark, On Tue, Jun 28, 2011 at 00:01:41, Grosen, Mark wrote: > > From: Nori, Sekhar > > Sent: Friday, June 24, 2011 8:44 AM > > To assert/de-assert local reset when enabling or disabling PSC, > > you could use a flag in the clock structure to indicate the need > > for this. This way, if there is any other module needing a local > > reset, it can just define the same flag. Similarly, if the DSP > > does not need a local reset on a particular platform, that > > platform can simply skip the flag. > > > > This can be done in a manner similar to how the support for > > a forced transition PSC was added here: > > > > https://patchwork.kernel.org/patch/662941/ > > Yes, I like this idea - much cleaner. For example, the start() method > becomes (pseudo-code): > > start() > { > /* bootaddrreg derived from platform data */ > bootaddrreg = boot_address; > > clk_enable(); > } > > Referring to your patch above, would it be better to just pass > the flags into the davinci_psc_config() function rather than breaking out more > arguments for each flag? I did dwell on this quite a bit while writing that patch, but finally decided on passing an argument instead since I was not sure if there are going to be more modifiers required. Now that you have the need for one more flag, I think we should go ahead and pass the flags directly to davinci_psc_config(). My original patch is not upstream yet. I will re-spin it and you can build on top of it. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
