> -----Original Message----- > From: Valkeinen, Tomi > Sent: Thursday, May 12, 2011 8:17 PM > To: Janorkar, Mayuresh > Cc: Igor Grinberg; linux-omap@xxxxxxxxxxxxxxx; Stanley Miao > Subject: RE: [PATCH 4/6] OMAP: LDP: Port the display driver to new DSS2 > > On Thu, 2011-05-12 at 20:06 +0530, Janorkar, Mayuresh wrote: > > > -----Original Message----- > > > From: Valkeinen, Tomi > > > Sent: Thursday, May 12, 2011 5:18 PM > > > To: Igor Grinberg > > > Cc: Janorkar, Mayuresh; tony@xxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; > > > Stanley Miao > > > Subject: Re: [PATCH 4/6] OMAP: LDP: Port the display driver to new > DSS2 > > > > > > On Thu, 2011-05-12 at 14:20 +0300, Igor Grinberg wrote: > > > > > > > Right. Do both fixes make it work? > > > > > > > > If it is, then Tomi, > > > > will you add both fixes to the patch set with our SOBs? > > > > or do you want this to be sent properly as a follow up? > > > > > > Yes, I can add these all to the same patch and handle it through DSS > > > tree. Although due to the reluctance to make changes to > arch/arm/*omap*, > > > I guess we'll pass these patches in this merge window. > > > > > > Mayuresh, if you're able to test this and it works, can you send me > the > > > full diff so that I don't make any mistakes combining the code? > > > > > > Tomi > > > > > > > Please find the patch below. > > I have also attached the same. > > > > There are formatting problems with this patch. But this can be used as a > reference. > > > > I have verified bootup with Penguins on LDP board. > > Why did you create a new panel for LDP? The generic panel driver should > handle it well enough. > > The attached panel driver is also quite messed up. It does things that > belong to the board file, and the timings are a bit high, giving refresh > rate of 120MHz. Does LDP have a 120MHz panel? You can use that code as reference and not as a patch. Please take a look at changes in board file. There is no need to create a new panel. It can be added as a part of generic panel. I have taken timings info from: drivers/video/omap/lcd_ldp.c #ifdef CONFIG_FB_OMAP_LCD_VGA #define LCD_XRES 480 #define LCD_YRES 640 #define LCD_PIXCLOCK_MAX 41700 #else #define LCD_XRES 240 #define LCD_YRES 320 #define LCD_PIXCLOCK_MAX 185186 #endif > > Tomi > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
