Hi Santosh, On Fri, Apr 29, 2011 at 1:29 PM, Santosh Shilimkar <santosh.shilimkar@xxxxxx> wrote: > On 4/29/2011 2:56 PM, jean.pihet@xxxxxxxxxxxxxx wrote: >> >> From: Jean Pihet<j-pihet@xxxxxx> >> >> The achievable power modes of the power domains in cpuidle >> depends on the system wide 'enable_off_mode' knob in debugfs. >> Upon changing enable_off_mode, do not change the C-states >> 'valid' field but instead dynamically restrict the power modes >> when entering idle. >> >> The C-states 'valid' field is just used to enable/disable some >> C-states at init and shall not be changed later on. >> >> Signed-off-by: Jean Pihet<j-pihet@xxxxxx> ... > Since you have started clean-up, we should get rid of the > "enable_off_mode" some how. I got that done for OMAP4 using > prepare() hook and IGNORE flag as per Kevin's suggestion > but unfortunately its seems to getting removed from > core cpuidle code. The idea is to remove the enable_off_mode knob from debugfs and instead have the devices constraints API control the power domains behavior. Cf. PATCH 0/5 of this series for some remarks about further clean-up work. Thanks! Jean > > Regards > Santosh > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html