* Manuel, Lesly Arackal <leslyam@xxxxxx> [110427 05:55]: > Hi Tony, > > On Mon, Apr 18, 2011 at 6:28 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > * Manuel, Lesly Arackal <leslyam@xxxxxx> [110418 15:52]: > >> > > >> > To me it seems this should go into drivers/mfd instead. > >> > The script may contain omap specific values, but can be > >> > a loadable driver module. > >> > >> - subsys_initcall(twl_init) > >> Â Â -> twl_probe() > >> Â Â Â -> twl4030_power_init() > >> Â Â Â Â -> load_twl4030_script() Â#to copy this script data to the PM IC. > >> > >> Since this is getting called from a subsys initcall, not sure whether > >> we can make this scripts as loadable module. > > > > AFAIK it does not need to do anything that early. Maybe take a look > > at initialing it later? > > > > The loading of script data & configuration of resource is one time process, > later HW will take care(executing the sequence in TWL based on > sys_offmode, clk_req, ...signal states) > > So any specific reason for making this twl script as loadable module? Because it should all be just a regular device driver living under drivers/. You can still pass the platform data to it, there should not be any need to initialize this earlier. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
