Re: [PATCH v9 4/9] OMAP3: PM: TWL4030 power scripts for OMAP3 boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tony,

On Mon, Apr 18, 2011 at 6:02 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> Hi,
>
> * Lesly A M <leslyam@xxxxxx> [110414 15:25]:
>> Power bus message sequence for TWL4030 to enter sleep/wakeup/warm_reset.
>>
>> TWL4030 power scripts which can be used by different OMAP3 boards
>> with the power companion chip (TWL4030 series).
>>
>> The twl4030 generic script can be used by any board file to update
>> the power data in twl4030_platform_data.
>>
>> http://omapedia.org/wiki/TWL4030_power_scripts
>>
>> Signed-off-by: Lesly A M <leslyam@xxxxxx>
>> Cc: Nishanth Menon <nm@xxxxxx>
>> Cc: David Derrick <dderrick@xxxxxx>
>> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
>> ---
>>  arch/arm/mach-omap2/twl4030-script.c |  331 ++++++++++++++++++++++++++++++++++
>>  arch/arm/mach-omap2/twl4030-script.h |   23 +++
>>  include/linux/i2c/twl.h              |   33 +++-
>>  3 files changed, 384 insertions(+), 3 deletions(-)
>>  create mode 100644 arch/arm/mach-omap2/twl4030-script.c
>>  create mode 100644 arch/arm/mach-omap2/twl4030-script.h
>
> To me it seems this should go into drivers/mfd instead.
> The script may contain omap specific values, but can be
> a loadable driver module.

- subsys_initcall(twl_init)
    -> twl_probe()
      -> twl4030_power_init()
        -> load_twl4030_script()  #to copy this script data to the PM IC.

Since this is getting called from a subsys initcall, not sure whether
we can make this scripts as loadable module.

>
> Maybe drivers/mfd/twl4030-script-omap.c?
Ok, fine

Regards,
Lesly A M
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux