Hi, On Mon, Mar 28, 2011 at 9:57 PM, Kevin Hilman <khilman@xxxxxx> wrote: > Vishwa, Shweta, > > Vishwanath Sripathy <vishwanath.bs@xxxxxx> writes: > > [...] > >>> I am testing Smartreflex on your Branch 'pm-wip/voltdm'. There seems >>> an issue with reading VP registers. >>> For OMAP3 and OMAP4 reading debugfs entries shows constant voltage. > > Thanks for testing. > > [...] > >> I did a quick debug on this and found that the root cause of the issue is >> in usage of ffs (because of this, i2c slave address was configured wrongly >> in vc). >> Basically ffs returns the position of the first (least significant) bit >> set in the word and the least significant bit is position 1 where as our >> bit operation assumes that least significant position is 0. > > Vishwa, Thanks for findingg this. Indeed, I had assumed ffs() was zero based, > but it is 1 based. > >> I tested the attached patch on OMAP3 and it seems to work fine. Attached, is Patch which fixes the Issue, It works Fine for OMAP3 and OMAP4 SDP boards. >> Kevin, >> You may want to incorporate this change in your next version if this seems >> OK to you. > > Yes, I will fix this in forthcoming versions. > > Thanks, > > Kevin > -- Thanks, Regards, Shweta
Attachment:
0001-OMAP2-PM-Ensure-Bitshifts-are-calculated-accurately.patch
Description: Binary data
