Re: [PATCH 1/5] OMAP3: l3: fix for "irq 10: nobody cared" message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/29/2011 10:50 PM, Omar Ramirez Luna wrote:
If an error occurs in the L3 on any other initiator than MPU,
the interrupt goes unhandled given that the 'base' register
was calculated with the initialized err_source value (which
coincidentally points to MPU) and not with the actual source
of the error.

Removed parenthesis that are not needed for the touched lines.

Signed-off-by: Omar Ramirez Luna<omar.ramirez@xxxxxx>
---

Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>

  arch/arm/mach-omap2/omap_l3_smx.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
index 5f2da75..4321e79 100644
--- a/arch/arm/mach-omap2/omap_l3_smx.c
+++ b/arch/arm/mach-omap2/omap_l3_smx.c
@@ -196,11 +196,11 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
  		/* No timeout error for debug sources */
  	}

-	base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
-
  	/* identify the error source */
  	for (err_source = 0; !(status&  (1<<  err_source)); err_source++)
  									;
+
+	base = l3->rt + *(omap3_l3_bases[int_type] + err_source);
  	error = omap3_l3_readll(base, L3_ERROR_LOG);

  	if (error) {

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux