On 3/29/2011 10:31 PM, Tony Lindgren wrote:
* Santosh Shilimkar<santosh.shilimkar@xxxxxx> [110328 22:47]:
From: Tony Lindgren [mailto:tony@xxxxxxxxxxx]
Do you really need to initialize all of this that early?
Yes. It's a interrupt controller extension and needs to work
together with GIC.
Hmm to me it seems that the gic_arch_extn functions should be
all NULL during runtime operation, and the wake-up generator
should be programmed only before entering an idle state.
Then the wake-up generator can be cleared after delivering
the wake-up event(s).
Or am I missing something on why this should be enabled all
the time?
Yep. The WakeupGen sits between GIC and CPU and can
gate the interrupts in normal operation too. It's
mandatory that the interrupt mask at GIC and WakeupGen
matches to deliver the interrupt to CPU.
This is the reason why all the necessary GIC hooks are
populated with it so that they work together.
So far without this patch all interrupts at WakeupGen
level were always enabled and hence there was no issue.
BTW, looks like you got few typos in the comments in this
patch, noticed these while reading:
Hardware requirements is
GIC rgeisters
gic architecture specific fucntioms
I do lot of them :(
Will fix these typos.
Regards
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
