Hi, > -----Original Message----- > From: ext Felipe Balbi [mailto:balbi@xxxxxx] > Sent: 28. maaliskuuta 2011 11:55 > To: Jokiniemi Kalle (Nokia-MS/Tampere) > Cc: balbi@xxxxxx; keshava_mgowda@xxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux- > omap@xxxxxxxxxxxxxxx; Krogerus Heikki (Nokia-MS/Helsinki); > jhnikula@xxxxxxxxx; khilman@xxxxxx > Subject: Re: [PATCH v2 2/2] RX-51: Enable isp1704 power on/off > > On Mon, Mar 28, 2011 at 08:52:23AM +0000, kalle.jokiniemi@xxxxxxxxx wrote: > > Hi, > > > > > -----Original Message----- > > > From: ext Felipe Balbi [mailto:balbi@xxxxxx] > > > Sent: 28. maaliskuuta 2011 11:39 > > > To: Jokiniemi Kalle (Nokia-MS/Tampere) > > > Cc: keshava_mgowda@xxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux- > > > omap@xxxxxxxxxxxxxxx; balbi@xxxxxx; Krogerus Heikki (Nokia- > MS/Helsinki); > > > jhnikula@xxxxxxxxx; khilman@xxxxxx > > > Subject: Re: [PATCH v2 2/2] RX-51: Enable isp1704 power on/off > > > > > > Hi, > > > > > > (break your lines at 80-chars, I asked you to do this before) > > > > Sorry, using outlook :( ... Will do that. > > > > > > > > On Mon, Mar 28, 2011 at 08:06:32AM +0000, kalle.jokiniemi@xxxxxxxxx > wrote: > > > > Hi, > > > > > > > > > -----Original Message----- > > > > > From: ext Keshava Munegowda [mailto:keshava_mgowda@xxxxxx] > > > > > Sent: 28. maaliskuuta 2011 10:19 > > > > > To: Jokiniemi Kalle (Nokia-MS/Tampere); linux-usb@xxxxxxxxxxxxxxx; > linux- > > > > > omap@xxxxxxxxxxxxxxx; Felipe Balbi > > > > > Cc: Krogerus Heikki (Nokia-MS/Helsinki); jhnikula@xxxxxxxxx; Kevin > Hilman > > > > > Subject: RE: [PATCH v2 2/2] RX-51: Enable isp1704 power on/off > > > > > > > > > > > + > > > > > > static struct platform_device rx51_charger_device = { > > > > > > - .name = "isp1704_charger", > > > > > > + .name = "isp1704_charger", > > > > > > > > > > Both are same; you don't need this change! > > > > > > > > No, actually they are not same. I added tab instead of space to match > > > > indentation with the .dev member. This is the correct way IMHO. > > > > > > Still, changing that indentation isn't part of $SUBJECT. You need to put > > > that in another patch. > > > > Are you sure? It'll be patch that changes indentation that need not be > > changed... Only the additional member definition makes the indentation > > necessary, hence I see it as natural part of this patch. > > > > But if that's a problem, I can do a separate patch, no problem. > > you need to at least add notes on the commit log explicit saying that > you're also fixing indentation of one member because it's not worth > having a separate patch and blablabla... Sounds fair, I'll do that. - Kalle > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
