On Fri, 2011-03-11 at 02:24 -0600, K, Mythri P wrote: > Hi Tomi, > > On Thu, Mar 10, 2011 at 8:36 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > > There is this code in dss.c: > > > > #ifdef CONFIG_OMAP2_DSS_VENC > > REG_FLD_MOD(DSS_CONTROL, 1, 4, 4); /* venc dac demen */ > > REG_FLD_MOD(DSS_CONTROL, 1, 3, 3); /* venc clock 4x enable */ > > REG_FLD_MOD(DSS_CONTROL, 0, 2, 2); /* venc clock mode = normal */ > > #endif > > > Regarding this piece of code , although it appears that is should not affect , > I think we should move this out of dss_init , if any such change is needed > we should do that on VENC enable dont you think ? Either we should enable them on venc_enable, or remove the ifdef. If there are side effects (which we don't know currently) we should use do them on venc_enable. If there aren't any side effects, we should just write the register always. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
