Hi Tomi, On Thu, Mar 10, 2011 at 8:36 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > Hi Mythri, > > On Thu, 2011-03-10 at 04:44 -0600, K, Mythri P wrote: >> Adding HDMI support on OMAP4. >> >> HDMI is a driver that is similar to the VENC or the DSI driver to support >> HDMI/DVI sink device. >> >> The current design adheres to the DSS2 architecture. > > I was testing this on Blaze, with VENC enabled in Kconfig and a small > hack in venc.c which skips registering the venc device on omap4. > > I haven't seen these earlier, so it may just be I've been lucky, or > enabling VENC affected this. > > I've seen this twice when loading the modules: > > [ 23.007690] omapdss HDMI: no valid timing found , falling back to VGA > [ 23.040161] omapdss HDMI error: PLL GO bit not set > [ 23.045196] omapdss HDMI error: failed to power on device > [ 23.050964] omapdss error: failed to power on > [ 23.055572] omapfb omapfb: Failed to enable display 'hdmi' > [ 23.066162] omapfb omapfb: failed to setup omapfb > [ 23.071166] omapfb: probe of omapfb failed with error -5 > > And I've seen this once when unloading modules: > > [ 126.473419] omapdss DISPC error: SYNC_LOST_DIGIT, disabling TV > [ 126.569244] omapdss DISPC error: timeout waiting for EVSYNC > [ 126.670776] omapdss DISPC error: timeout waiting for EVSYNC > [ 126.773376] omapdss HDMI: no valid timing found , falling back to VGA > [ 126.881896] omapdss DISPC error: timeout waiting for EVSYNC > [ 126.983367] omapdss DISPC error: timeout waiting for EVSYNC > rmmod: can't unload 'omapdss': Resource temporarily unavailable > > This looks a bit bad, as it sounds to me that when an error happened, > some code path returned too early and the omapdss driver could not > unload. > I tried loading and unloading around 10-15 times and did not hit the problem, Can you please paste the entire log ? Did you see this only when VENC was enabled? > There is this code in dss.c: > > #ifdef CONFIG_OMAP2_DSS_VENC > REG_FLD_MOD(DSS_CONTROL, 1, 4, 4); /* venc dac demen */ > REG_FLD_MOD(DSS_CONTROL, 1, 3, 3); /* venc clock 4x enable */ > REG_FLD_MOD(DSS_CONTROL, 0, 2, 2); /* venc clock mode = normal */ > #endif > Regarding this piece of code , although it appears that is should not affect , I think we should move this out of dss_init , if any such change is needed we should do that on VENC enable dont you think ? > They don't sound like they would affect HDMI, but that was the only > difference I found (between VENC enabled and disabled) with a quick > search. > > Tomi > Thanks and regards, Mythri. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
