> -----Original Message----- > From: Valkeinen, Tomi > Sent: Wednesday, March 16, 2011 12:15 PM > To: Hiremath, Vaibhav > Cc: K, Mythri P; Stephan Raue; linux-omap@xxxxxxxxxxxxxxx > Subject: RE: [PATCH v5 00/10] OMAP4 : DSS2 : HDMI support on OMAP4 > > On Mon, 2011-03-14 at 04:35 -0500, Hiremath, Vaibhav wrote: > > > -----Original Message----- > > > From: Valkeinen, Tomi > > > Sent: Monday, March 14, 2011 2:55 PM > > > To: Hiremath, Vaibhav > > > Cc: K, Mythri P; Stephan Raue; linux-omap@xxxxxxxxxxxxxxx > > > Subject: RE: [PATCH v5 00/10] OMAP4 : DSS2 : HDMI support on OMAP4 > > <snip> > > > > > Personally I don't know any platform is implementing this function > OR > > > how one should make use of it. I remember last time we had similar > > > discussion and the comment came was, restore only required in case of > off > > > mode. I feel, this is not applicable here, since irrespective of > > > retention/inactive/off mode if driver is disabling clock for the > > > peripheral we must restore the context. > > > > > > I don't know about OMAP4, but on OMAP3 the register contents are only > > > lost when DSS goes to OFF mode. If you just turn off the clocks and > OFF > > > mode is not enabled in the PM, context restore is not needed. I am not > > > sure of the current status of OFF mode in the mainline kernel. > > > > > > However, for some reason DSS works fine on my Overo board. I would > > > imagine that it would break also if OFF is enabled for all omap > > > boards... > > > > > > As for get_last_off_on_transaction_id(), it seems to be called > > > get_context_loss_count() in the mainline kernel and returns u32, not > > > int. I haven't tested it, but get_last_off_on_transaction_id pointer > in > > > the dss platform data should be set to get_context_loss_count in the > > > board file (or in arch/arm/plat-omap/display.c if using the dss2 tree). > > > > > [Hiremath, Vaibhav] Let me try this out. > > Did you have time to test this? > [Hiremath, Vaibhav] Yesterday got pulled into different issue, will try today. Thanks, Vaibhav > Tomi > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
