Hello Tarun, On Tue, 4 Jan 2011, Tarun Kanti DebBarma wrote: > Autoidle is a single bit, TIOCP_CFG[0], setting on OMAP1/2/3/4 platforms. > In _set_module_autoidle() I am seeing 0x3 value where the mask is computed. > This should be 0x1. > > v2: > (1) Modified the subject. > (2) Modified the description with further specific information. > > Baseline: > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git > > Tested Info: > Boot tested on OMAP 1/2/3/4. > > Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@xxxxxx> > Acked-by: Rajendra Nayak <rnayak@xxxxxx> > Acked-by: Benoit Cousson <b-cousson@xxxxxx> Thanks, nice catch. Queued for 2.6.39. - Paul > --- > arch/arm/mach-omap2/omap_hwmod.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c > index 5a30658..da49b56 100644 > --- a/arch/arm/mach-omap2/omap_hwmod.c > +++ b/arch/arm/mach-omap2/omap_hwmod.c > @@ -373,7 +373,7 @@ static int _set_module_autoidle(struct omap_hwmod *oh, u8 autoidle, > } > > autoidle_shift = oh->class->sysc->sysc_fields->autoidle_shift; > - autoidle_mask = (0x3 << autoidle_shift); > + autoidle_mask = (0x1 << autoidle_shift); > > *v &= ~autoidle_mask; > *v |= autoidle << autoidle_shift; > -- > 1.6.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
