Re: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Santosh Shilimkar <santosh.shilimkar@xxxxxx> [110221 11:01]:
> > -----Original Message-----
> > From: Cousson, Benoit [mailto:b-cousson@xxxxxx]
> > Sent: Monday, February 21, 2011 11:41 PM
> > To: Shilimkar, Santosh
> > Cc: linux-omap@xxxxxxxxxxxxxxx; Balbi, Felipe; R, Sricharan
> > Subject: Re: [PATCH 5/6] omap4: Initialise the l3 device with the
> > hwmod data.
> >
> > On 2/21/2011 2:46 PM, Shilimkar, Santosh wrote:
> > > From: sricharan<r.sricharan@xxxxxx>
> > >
> > > The l3 interconnect device is build with all the data required
> > > to handle the error logging. The data is extracted from the
> > > hwmod data base.
> > >
> > > Signed-off-by: sricharan<r.sricharan@xxxxxx>
> > > Signed-off-by: sricharan<r.sricharan@xxxxxx>
> > > Tested-by: sricharan<r.sricharan@xxxxxx>
> >
> > Mmm, I'm not sure the tested-by is meaningfull in your case, since
> > you wrote the code and so everybody will assume you tested it.
> > One s-o-b should be probably enough.
> >
> 
> Well he tested whole series including the patch from Felipe.
> So a tested-by on whole series doesn't hurt, right ?
> 
> Just for record, I have seen tested by applied on whole series
> Where as some of the patches in this series are just comment
> updates.

Well Signed-off-by also means Tested-by. If not, it should
be specifically mentioned when the patch is posted. Something
like "PLEASE NOTE THAT THIS PATCH IS COMPLETELY UNTESTED".

Also one Signed-off-by is enough like Benoit pointed out :)

Tony



--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux