Hi Benoît, On Tue, 1 Mar 2011, Cousson, Benoit wrote: > So to conclude, I will drop the #3 and just push #1 and #2. > > #1 is fine with addition of the WARN. We should probably drop this one now that _setup() is allowed to be called on hwmods that have already been setup (commit 48d54f3f). > #2 does return an error but does not print anything, but since each call > (_init_main_clk, _init_interface_clks, _init_opt_clks) does report > some pr_warn in case of error, this is fine. #2 looks fine to me. - Paul