Hi Benoit, > -----Original Message----- > From: Cousson, Benoit [mailto:b-cousson@xxxxxx] > Sent: Wednesday, February 16, 2011 6:37 PM > To: Nayak, Rajendra > Cc: linux-omap@xxxxxxxxxxxxxxx; paul@xxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 0/3] OMAP2+ hwmod fixes > > Hi Rajendra, > > On 2/16/2011 1:11 PM, Nayak, Rajendra wrote: > > This series fixes some hwmod api return values > > and also adds some state checks. > > The hwmod iterator functions are made to > > continue and not break if one of the > > callback functions ends up with an error. > > By doing that, you change the behavior of this function. > I'm not sure I fully understand why. > Could you elaborate on the use case? Since these functions iterate over all hwmods calling a common callback function, there might be cases wherein the callback function for *some* hwmods might fail. For instance, if you run through all hwmods and try to clear the context registers for all of them, for some hwmods which might not have context registers the callback function might return a -EINVAL, however that should not stop you from attempting to clear the context registers for the rest of the hwmods which have them and abort the function midway, no? This is more hypothetical, however the real usecase that prompted me with this patch was when I had some wrong state check in _setup function, and the iterator would stop with the first failure and not even attempt to setup the rest of the hwmods. > > To avoid that behavior in the past, I was just returning > 0 in case of failure to avoid stopping the iteration. > It looks like you do not want to stop the iteration but still > retrieve the error. > I do not see in this series what you plan to do with the > error at the end of the iteration. Most users of these iterators would just use the non-zero return value to throw an error/warning out stating there were failures running through all the callback functions. That does not change with this patch, and they can still do it. Regards, Rajendra > > Thanks, > Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
