> -----Original Message----- > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > Sent: Friday, February 25, 2011 11:47 PM > To: Premi, Sanjeev > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] omap2plus: Remove auto selection on PMICs > > * Sanjeev Premi <premi@xxxxxx> [110223 04:11]: > > The current implementation almost assumes that only > > TWL4030/TWL5030/TWl6030 are (or can be) used with the > > OMAP processors. This is, however, not true. > > If selecting these on platforms that don't have twl > causes problems the problem should be fixed. > > You can disable CONFIG_ARCH_OMAP2PLUS_TYPICAL, and > then these don't get selected. [sp] But this means MUTLI_OMAP breaks. And same uImage won't run on the AM3517 EVM. If I remember, the problem is caused due to twl specific functions called even if it isn't present. And there is implicit assumption on TWL in most of code. > > > This patch removes the automatic selection of the PMIC > > from Kconfig. Current defaults are chosen in default > > configuration omap2plus_defconfig and can easily be > > added to configuration for any board, there should be > > no compile/run-time impact. > > The reason for CONFIG_ARCH_OMAP2PLUS_TYPICAL is to > produce a booting kernel if you do the following: > > $ echo CONFIG_ARCH_OMAP=y > .config > $ yes "" | ARCH=arm make oldconfig > $ ARCH=arm CROSS_COMPILE=mycompiler uImage > > So I'd rather keep it around for now. In the long run > omap2plus_defconfig should build a working kernel with > everything as modules though.. [sp] I will be away from work for next week; may not be able to try this; but don't you think dependency on ARM is too generic? And this should still be fixed.. - depends on TWL4030_CORE && ARM + depends on TWL4030_CORE && (ARCH_OMAP3 || ARCH_OMAP4) ~sanjeev > > BTW, looks like small patch is needed with the patches queued > in omap-for-linus to make the above compile. Will post > as a reply to this mail. > > Regards, > > Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
