Re: [PATCH 01/12] omap3: pm: Fix for the TRITON sleep/wakeup sequence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi David,

On Sat, Feb 19, 2011 at 5:08 AM, David Cohen <dacohen@xxxxxxxxx> wrote:
> Hi,
>
> On Fri, Feb 18, 2011 at 7:08 PM, Lesly A M <leslyam@xxxxxx> wrote:
>> Since the function to populate the sleep script is getting called always
>> irrespective of the flag "TWL4030_SLEEP_SCRIPT", other scripts data
>> is getting over written by the sleep script.
>
> Are you sure this is the correct patch description? For me it's something like:
> Add missing brackets to if statement.

Yes, adding the missing brackets, to fix this issue.
Ok, I will include "adding the missing brackets" in the change log.

Regards,
Lesly AM
>>
>> Signed-off-by: Lesly A M <leslyam@xxxxxx>
>> Cc: Nishanth Menon <nm@xxxxxx>
>> Cc: David Derrick <dderrick@xxxxxx>
>> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
>> ---
>>  drivers/mfd/twl4030-power.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
>> index 16422de..2c0d4d1 100644
>> --- a/drivers/mfd/twl4030-power.c
>> +++ b/drivers/mfd/twl4030-power.c
>> @@ -447,12 +447,13 @@ static int __init load_twl4030_script(struct twl4030_script *tscript,
>>                if (err)
>>                        goto out;
>>        }
>> -       if (tscript->flags & TWL4030_SLEEP_SCRIPT)
>> +       if (tscript->flags & TWL4030_SLEEP_SCRIPT) {
>>                if (order)
>>                        pr_warning("TWL4030: Bad order of scripts (sleep "\
>>                                        "script before wakeup) Leads to boot"\
>>                                        "failure on some boards\n");
>>                err = twl4030_config_sleep_sequence(address);
>> +       }
>>  out:
>>        return err;
>>  }
>> --
>> 1.7.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux