Hi, On Fri, Feb 18, 2011 at 7:08 PM, Lesly A M <leslyam@xxxxxx> wrote: > Since the function to populate the sleep script is getting called always > irrespective of the flag "TWL4030_SLEEP_SCRIPT", other scripts data > is getting over written by the sleep script. Are you sure this is the correct patch description? For me it's something like: Add missing brackets to if statement. Br, David Cohen > > Signed-off-by: Lesly A M <leslyam@xxxxxx> > Cc: Nishanth Menon <nm@xxxxxx> > Cc: David Derrick <dderrick@xxxxxx> > Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> > --- > Âdrivers/mfd/twl4030-power.c | Â Â3 ++- > Â1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > index 16422de..2c0d4d1 100644 > --- a/drivers/mfd/twl4030-power.c > +++ b/drivers/mfd/twl4030-power.c > @@ -447,12 +447,13 @@ static int __init load_twl4030_script(struct twl4030_script *tscript, > Â Â Â Â Â Â Â Âif (err) > Â Â Â Â Â Â Â Â Â Â Â Âgoto out; > Â Â Â Â} > - Â Â Â if (tscript->flags & TWL4030_SLEEP_SCRIPT) > + Â Â Â if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > Â Â Â Â Â Â Â Âif (order) > Â Â Â Â Â Â Â Â Â Â Â Âpr_warning("TWL4030: Bad order of scripts (sleep "\ > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â"script before wakeup) Leads to boot"\ > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â"failure on some boards\n"); > Â Â Â Â Â Â Â Âerr = twl4030_config_sleep_sequence(address); > + Â Â Â } > Âout: > Â Â Â Âreturn err; > Â} > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html