Hi, >-----Original Message----- >From: Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxx] >Sent: Wednesday, February 16, 2011 5:31 PM >To: Hema HK >Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx >Subject: Re: > >On 16-02-2011 14:53, Hema HK wrote: > >> From: Hema HK<hemahk@xxxxxx > >> Moved all the board specific internal PHY functions out of >usb_musb.c file >> as this file is shared between the OMAP2+ and AM35xx platforms. >> There exists a file which has the functions specific to internal PHY >> used for OMAP4 platform. Moved all phy specific functions to >this file >> and passing these functions through board data in the board file. > >> Signed-off-by: Hema HK<hemahk@xxxxxx> > >> Index: linux-2.6/arch/arm/mach-omap2/board-am3517evm.c >> =================================================================== >> --- linux-2.6.orig/arch/arm/mach-omap2/board-am3517evm.c >> +++ linux-2.6/arch/arm/mach-omap2/board-am3517evm.c >> @@ -409,6 +409,10 @@ static struct omap_musb_board_data musb_ >> .interface_type = MUSB_INTERFACE_ULPI, >> .mode = MUSB_OTG, >> .power = 500, >> + .set_phy_power = am35x_musb_phy_power, >> + .clear_irq = am35x_musb_clear_irq, >> + .set_mode = am35x_musb_set_mode, >> + .reset = am35x_musb_reset, >> }; >> >> static __init void am3517_evm_musb_init(void) >[...] >> Index: linux-2.6/arch/arm/mach-omap2/Makefile >> =================================================================== >> --- linux-2.6.orig/arch/arm/mach-omap2/Makefile >> +++ linux-2.6/arch/arm/mach-omap2/Makefile >> @@ -218,7 +218,8 @@ obj-$(CONFIG_MACH_OMAP4_PANDA) += board >> hsmmc.o \ >> omap_phy_internal.o >> >> -obj-$(CONFIG_MACH_OMAP3517EVM) += board-am3517evm.o >> +obj-$(CONFIG_MACH_OMAP3517EVM) += board-am3517evm.o \ >> + omap_phy_internal.o \ >> >> obj-$(CONFIG_MACH_CRANEBOARD) += board-am3517crane.o > > Doesn't the above board needs board data modified as well? There is no "musb_board_data" for the above board file. Regards, Hema > >WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
