Hi Paul, > -----Original Message----- > From: linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx [mailto:linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf > Of Paul Walmsley > Sent: Wednesday, February 16, 2011 12:23 PM > To: linux-omap@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: [PATCH 00/11] OMAP2+: clock: add clockfw autoidle for iclks, OMAP2xxx > > Hello, > > This patch series adds clock framework-controlled autoidle support for > the OMAP2xxx DPLL, APLLs, and OMAP2/3 interface clocks. The old > direct register writes in the PM code to enable clock autoidle have been > removed. > > This series also ensures that all clock autoidle is disabled during > boot and only re-enabled if CONFIG_PM is enabled. This does not seem to be the case. Maybe something like the below patch is what is missing.. --- >From 572bf95cf4aa3d3a1c73254f67e27e62f108f4e1 Mon Sep 17 00:00:00 2001 From: Rajendra Nayak <rnayak@xxxxxx> Date: Wed, 16 Feb 2011 14:56:35 +0530 Subject: [PATCH] OMAP2+: PM: Enable all clk autoidle only if CONFIG_PM Autoidle for all clocks is disabled during clock framework initialization. Enable them here (late in the boot process) only if CONFIG_PM is enabled. While here, also update the comment to remove the TODO's which are already addressed. Signed-off-by: Rajendra Nayak <rnayak@xxxxxx> --- arch/arm/mach-omap2/pm.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c index b507702..f888986 100644 --- a/arch/arm/mach-omap2/pm.c +++ b/arch/arm/mach-omap2/pm.c @@ -262,13 +262,14 @@ static int __init omap2_common_pm_late_init(void) /* Smartreflex device init */ omap_devinit_smartreflex(); +#ifdef CONFIG_PM /* - * Set all OMAP3/4 DPLLs to autoidle. - * XXX TODO: Add all the iclk autoidles in here as well, - * the OMAP2 DPLL, the OMAP2 APLLs, and the AUTOEXTCLKMODE - * control here too. + * Set all OMAP2/3/4 DPLLs to autoidle. + * Set OMAP2 APLLs, and the AUTOEXTCLKMODE to autoidle. + * Set all the iclk autoidle, */ omap_clk_enable_autoidle_all(); +#endif return 0; } -- 1.7.0.4
Attachment:
0001-OMAP2-PM-Enable-all-clk-autoidle-only-if-CONFIG_PM.patch
Description: Binary data
