On Mon, Feb 14, 2011 at 3:18 PM, Felipe Balbi <balbi@xxxxxx> wrote: > Hi, Hi > > On Mon, Feb 14, 2011 at 02:07:08PM +0100, Laurent Pinchart wrote: >> > > diff --git a/arch/arm/mach-omap2/devices.h >> > > b/arch/arm/mach-omap2/devices.h new file mode 100644 >> > > index 0000000..12ddb8a >> > > --- /dev/null >> > > +++ b/arch/arm/mach-omap2/devices.h >> > > @@ -0,0 +1,17 @@ >> > > +/* >> > > + * arch/arm/mach-omap2/devices.h >> > > + * >> > > + * OMAP2 platform device setup/initialization >> > > + * >> > > + * This program is free software; you can redistribute it and/or modify >> > > + * it under the terms of the GNU General Public License as published by >> > > + * the Free Software Foundation; either version 2 of the License, or >> > > + * (at your option) any later version. >> > > + */ >> > > + >> > > +#ifndef __ARCH_ARM_MACH_OMAP_DEVICES_H >> > > +#define __ARCH_ARM_MACH_OMAP_DEVICES_H >> > > + >> > > +int omap3_init_camera(void *pdata); >> > >> > missing extern ? >> >> Is that mandatory ? Many (most ?) headers in the kernel don't use the extern >> keyword when declaring functions. > > maybe not mandatory, worth checking what sparse would say though :-p sparse is not complaining. Br, David > > -- > balbi > -- -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
