Hi Felipe,
On Monday 14 February 2011 13:34:30 Felipe Balbi wrote:
> On Mon, Feb 14, 2011 at 01:21:30PM +0100, Laurent Pinchart wrote:
> > diff --git a/arch/arm/mach-omap2/devices.c
> > b/arch/arm/mach-omap2/devices.c index d389756..4cf48ea 100644
> > --- a/arch/arm/mach-omap2/devices.c
> > +++ b/arch/arm/mach-omap2/devices.c
> > @@ -34,6 +34,8 @@
[snip]
> > +int omap3_init_camera(void *pdata)
> > {
> > + omap3isp_device.dev.platform_data = pdata;
> > + return platform_device_register(&omap3isp_device);
> > }
> > -#endif
> > +EXPORT_SYMBOL_GPL(omap3_init_camera);
>
> if you EXPORT_SYMBOL_GPL() then also modules can poke with this, right ?
> isn't it enough to just put an "extern int omap3_init_camera(void *);"
> on a header ?
It wasn't before as board code needed to be compiled as a module, but we've
fixed that. I'll remove the EXPORT_SYMBOL_GPL.
> BTW, you know the correct type of the platform_data, so why not passing
> the correct type instead of void * ?? Then, compile will help you if you
> pass wrong type, right ?
Agreed. I'll fix that.
> > diff --git a/arch/arm/mach-omap2/devices.h
> > b/arch/arm/mach-omap2/devices.h new file mode 100644
> > index 0000000..12ddb8a
> > --- /dev/null
> > +++ b/arch/arm/mach-omap2/devices.h
> > @@ -0,0 +1,17 @@
> > +/*
> > + * arch/arm/mach-omap2/devices.h
> > + *
> > + * OMAP2 platform device setup/initialization
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
> > +
> > +#ifndef __ARCH_ARM_MACH_OMAP_DEVICES_H
> > +#define __ARCH_ARM_MACH_OMAP_DEVICES_H
> > +
> > +int omap3_init_camera(void *pdata);
>
> missing extern ?
Is that mandatory ? Many (most ?) headers in the kernel don't use the extern
keyword when declaring functions.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
