Nishanth Menon wrote, on 02/02/2011 07:59 AM:
Kevin Hilman wrote, on 02/02/2011 04:11 AM:
Shweta Gulati<shweta.gulati@xxxxxx> writes:
From: Thara Gopinath<thara@xxxxxx>
The smartreflex bit on twl4030 needs to be enabled by default
irrespective
of whether smartreflex module is enabled on the OMAP side or not.
This is because without this bit enabled the voltage scaling through
vp forceupdate does not function properly on OMAP3.API added
'omap3_twl_set_sr_bit' with parameter to set/clear SR bit. It is cleared
for platforms where voltage is not scaled using vpforceupdate
or vc_bypass Method. In those cases 'omap3_twl_set_sr_bit' is called
from board file, to make sure this bit is not overwritten in
'omap3_twl_init', a flag 'twl_sr_enable'
is added.
As Sanjeev pointed out, the use of 'irrespective' above is confusing, in
fact the whole changelog is kind of confusing.
The changelog states that it has to always be enabled, but then goes on
to describe the situation(s) where it would be disabled.
Here's my rephrasing of how I understand the above changelog
- enable: *always* be enabled
- enable: needed for VP force update
- disable: platforms using VP forced update or VP bypass
-ECONFUSED
Kevin
How about this as the commit log?
my bad - I just saw that Shweta already posted a v3:
http://marc.info/?l=linux-omap&m=129612341602728&w=2
could we have the discussion there instead of beating up this old patch? ;)
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
