On Wed, Jan 19, 2011 at 11:10 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * Kevin Hilman <khilman@xxxxxx> [110119 13:37]: >> Kevin Hilman <khilman@xxxxxx> writes: >> >> > jean.pihet@xxxxxxxxxxxxxx writes: >> > >> >> From: Jean Pihet <j-pihet@xxxxxx> >> >> >> >> The new fncpy API is better suited for copying some >> >> code to SRAM at runtime. This patch changes the ad-hoc >> >> code to the more generic fncpy API. >> >> >> >> Tested OK on OMAP3 in low power modes (RET/OFF) >> >> using omap2plus_defconfig with !CONFIG_THUMB2_KERNEL. >> >> Compile tested on OMAP1/2 using omap1_defconfig. >> >> >> >> Signed-off-by: Jean Pihet <j-pihet@xxxxxx> >> > >> > Acked-by: Kevin Hilman <khilman@xxxxxx> >> > >> > Boot tested on OMAP1 & OMAP2 as well. Note that neither OMAP1 or OMAP2 >> > has had working suspend/resume for a long time now, so I did not test >> > suspend/resume. >> >> For OMAP2: >> >> Tested-by: Kevin Hilman <khilman@xxxxxx> >> >> to test a little more on OMAP2, I just removed the WFI from the >> low-level code and tested suspend that way. That's enough to be sure >> the copied code is copied and executed. >> >> Worked fine on OMAP2420/n810. >> >> For OMAP1, this didn't work and would require more serious hacking on >> the OMAP1 suspend path, which I currently have no plans to do. > > Boots fine on osk5912 and n800 too: > > Tested-by: Tony Lindgren <tony@xxxxxxxxxxx> > Thanks for testing! Regards, Jean -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html