On Wed, 2011-01-12 at 11:20 +0000, ext Ben Tucker wrote: > > -----Original Message----- > > From: Tomi Valkeinen [mailto:tomi.valkeinen@xxxxxxxxx] > > Sent: 12 January 2011 09:14 > > To: ext Ben Tucker > > Cc: linux-omap@xxxxxxxxxxxxxxx > > Subject: Re: OMAP DSS Enable clocks in dss_setup_partial_planes > > > > Hi, > > > > On Tue, 2011-01-11 at 17:41 +0000, ext Ben Tucker wrote: > > > From 086e3454c8f154cd90a4669899f2179f16ef32cd Mon Sep 17 00:00:00 > > 2001 > > > From: Ben Tucker <btucker@xxxxxxxxxxxxxx> > > > Date: Thu, 13 Jan 2011 12:56:45 +0000 > > > Subject: [PATCH] OMAP DSS Enable clocks in dss_setup_partial_planes > > > Enable the interface clocks while calling> > > > > configure_dispc(). > > > > This description doesn't really tell anything which isn't selfevident > > from the code below. Please check > > http://who-t.blogspot.com/2009/12/on-commit-messages.html > > > > But I presume this is about RFBI. If so, correct place to enable the > > clocks would be in rfbi.c. > > > > Tomi > > > > Apologies for the commit message. Updated patch below. > > Are you sure the code to enable clocks should be placed in rfbi.c? The DSI > code (dsi.c) uses dss_setup_partial_planes() in the same way as rfbi.c and > there is no clock enable code there. Also omap_dss_mgr_apply() within > manager.c enables clocks for the configure_dispc() call. Usually the user should enable the clocks, in this case rfbi.c. DSI handles this so that the clocks are always enabled when the display is enabled. This could be easier for RFBI also, but due to legacy reasons RFBI currently tries to keep clocks disabled except when its actually doing something. As for omap_dss_mgr_apply(), that function is also a "user" in this case. Apply is called from outside DSS driver, usually from omapfb. If the clk_enable/disable calls would be in the lower levels, this would mean a) greater overhead from clk_enable/disable calls and b) context saves and restores, as the DSS HW could go into OFF mode when the clocks are disabled. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
