> -----Original Message----- > From: Nishanth Menon [mailto:nm@xxxxxx] > Sent: Saturday, January 08, 2011 1:25 AM > To: Premi, Sanjeev > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [RFC] omap3: Enable SmartReflex calculations for 720MHz > > Sanjeev Premi had written, on 01/07/2011 11:26 AM, the following: [snip]...[snip] > Sorry, Dumb question: > a) You are using OPP5's nTarget to use in OPP6's nTarget? > is'nt it fused > in for OPP6 offset? > b) you are using OMAP343X_CONTROL_FUSE_OPP5_VDD1 itself > c) these should be __init functions. > d) how would you allow this code to work with 3440? > e) next time could you please try STOP using CaMELCASInG in your > variables and functions? > f) please add sufficient documentation in kernel-doc style to > allow us > to understand the story below? > g) dont use magic numbers > h) please take care of ROUND_DOWN and ROUND_UP and truncation errors > i) is this equation ONLY valid for opp5 ntarget modification on > OMAP3530? or valid for 3440 as well? or valid for any OPP ntarget > modification? > Under garb of asking dumb questions, you seem to be exposing yourself as one!! (Specifically since we exchanged multiple private emails on this topic yesterday) You have completely missed the whole intent of this RFC: 1) Look for possible problems that might arise because adding additional entry in the omap34xx_vddmpu_volt_data[] I didn't thinks so, since the array is static data and currently this array size is related to the array holding nValues for each OPP. 2) Look for advice on (or work in procress if) any that may help fix the kludge in the code section marked FIXME where better mechanism is required to extract the nvalues corresponding to OPP5. 3) Use this weekend to esp the lead time available due to time difference to have something valuable to start working on the I would have loved to see coding and documentation related comments had this been a formal patch. I will respond to some of other 'valid' queries in separate mail. Have tried to stop myself a lot before, but couldn't find a better way to respond :) ~sanjeev [snip]...[snip]-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
