> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxx] > Sent: Friday, January 07, 2011 10:18 PM > To: Premi, Sanjeev > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] omap3: Add basic support for 720MHz part > > Sanjeev Premi <premi@xxxxxx> writes: > > > This patch adds support for new speed enhanced parts with ARM > > and IVA running at 720MHz and 520MHz respectively. These parts > > can be probed at run-time by reading PRODID.SKUID[3:0] at > > 0x4830A20C [1]. > > Please expand this a little to describe exactly which parts have this > feature. All OMAP3? 34xx? 35xx? what about 36xx/37xx? ISTR the > runtime probing for this feature is available on 35xx but not on 34xx, > but a summary of this should be here. > [sp] Will update... [snip]...[snip] > nit: Unrelated to this patch, but OMAP3EVM ethernet is still > broken due to > missing GPIO configuration for the network reset. This has > been broken > since the GPIO hwmod merge and pointed out but nobody seems > to be fixing > it. [sp] It is currently in works. [snip]...[snip] > > + omap34xx_opp_def_list[INDEX_MPU_720MHZ] > > + .default_available = true; > > + omap34xx_opp_def_list[INDEX_IVA_720MHZ] > > + .default_available = true; > > + } > > + > > I'm with Nishanth here. Please stick to the OPP API for > enabling OPPs. > > First, it is future proof to internal table changes, but it > also sets a > better precedent for others wanting to fiddle with OPPs. > [sp] Okay. I will have to revert the a patch on my repo to to get there. Will send an update patch on MON. > Thanks, > > Kevin [snip]...[snip] -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
