Nishanth Menon <nm@xxxxxx> writes: > omap_enable_smartreflex_on_init is meant to be used by boards > which would like to have SR enabled by default on the platform, while > omap_devinit_smartreflex is used by pm code, the protos are defined > in pm.h. This header should be included to ensure that sr_device > function definitions match the prototypes. > > including pm.h fixes the sparse warnings (with CONFIG_OMAP_SMARTREFLEX=y): > arch/arm/mach-omap2/sr_device.c:138:13: warning: symbol 'omap_enable_smartreflex_on_init' was not declared. Should it be static? > arch/arm/mach-omap2/sr_device.c:143:12: warning: symbol 'omap_devinit_smartreflex' was not declared. Should it be static? > > Signed-off-by: Nishanth Menon <nm@xxxxxx> Thanks, will queue as a fix for 2.6.38-rc cycle. Kevin > Based on: > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git > branch: omap-for-linus > > arch/arm/mach-omap2/sr_device.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/sr_device.c b/arch/arm/mach-omap2/sr_device.c > index 786d685..b1e0af1 100644 > --- a/arch/arm/mach-omap2/sr_device.c > +++ b/arch/arm/mach-omap2/sr_device.c > @@ -27,6 +27,7 @@ > #include <plat/voltage.h> > > #include "control.h" > +#include "pm.h" > > static bool sr_enable_on_init; -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
