"Gopinath, Thara" <thara@xxxxxx> writes: >>>-----Original Message----- >>>From: Hilman, Kevin >>>Sent: Wednesday, January 05, 2011 4:18 AM >>>To: Gopinath, Thara >>>Cc: linux-omap@xxxxxxxxxxxxxxx; paul@xxxxxxxxx; Cousson, Benoit; Sripathy, >>>Vishwanath; Sawant, Anand; Menon, Nishanth >>>Subject: Re: [PATCH] OMAP3: PM: Adding T2 enabling of smartreflex >>> >>>Thara Gopinath <thara@xxxxxx> writes: >>> >>>> The smartreflex bit on twl4030 needs to be enabled by default >>>irrespective >>>> of whether smartreflex module is enabled on the OMAP side or not. >>>> This is because without this bit enabled the voltage scaling through >>>> vp forceupdate does not function properly on OMAP3. >>> >>>Based on Nishanth's comments, the abofe statements need a little more >>>justification. >>> >>>What is probably needed is some default setting (possibly this one) but >>>with the possibility of board code to disable this if needed. > > Yes. If we need to support the other means of voltage scaling, we > definitely need to override this bit from board files. I am not so > convinced that we need to support them though. IMHO, this patch can > still go in with change in the comment and if needed, there can be > another patch with an API in omap_twl.c allowing overriding/ > enabling-disabling of sr - i2c bit on the T2 side. I'm OK with this. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
