> -----Original Message----- > From: Russell King - ARM Linux [mailto:linux@xxxxxxxxxxxxxxxx] > Sent: Wednesday, January 05, 2011 4:50 PM > To: Santosh Shilimkar > Cc: linux-omap@xxxxxxxxxxxxxxx; khilman@xxxxxx; Nishanth Menon; > tony@xxxxxxxxxxx; Kevin Hilman; Thara Gopinath; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 5/5] omap2plus: voltage: Trivial linking fix > for'EINVAL' undeclared > > On Wed, Jan 05, 2011 at 04:27:04PM +0530, Santosh Shilimkar wrote: > > CC arch/arm/mach-omap2/omap_hwmod_common_data.o > > In file included from arch/arm/plat- > omap/include/plat/omap_hwmod.h:38, > > from arch/arm/mach- > omap2/omap_hwmod_common_data.c:20: > > arch/arm/plat-omap/include/plat/voltage.h: In function > 'omap_voltage_late_init': > > arch/arm/plat-omap/include/plat/voltage.h:145: error: 'EINVAL' > undeclared (first use in this function) > > arch/arm/plat-omap/include/plat/voltage.h:145: error: (Each > undeclared identifier is reported only once > > arch/arm/plat-omap/include/plat/voltage.h:145: error: for each > function it appears in.) > > make[1]: *** [arch/arm/mach-omap2/omap_hwmod_common_data.o] Error > 1 > > make: *** [arch/arm/mach-omap2] Error 2 > > The correct include for this is linux/errno.h, not linux/err.h - you > want the errno definitions, not the IS_ERR/PTR_ERR/ERR_PTR stuff. In this series, newly added stub of 'omap_voltage_domain_lookup' in [PATCH v2 4/5] make use of 'ERR_PTR' which needs linux/err.h. Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
