On Tue, Jan 04, 2011 at 04:29:04PM -0800, Kevin Hilman wrote: > tom.leiming@xxxxxxxxx writes: > > > From: Ming Lei <tom.leiming@xxxxxxxxx> > > > > Panda uses twl6030 otg phy instead of internal phy, This is wrong, it uses both. TWL6030 handles VBUS and ID pin and the internal PHY handles Data Lines. I know it's a bit crazy but this kind of design is becoming more and more usual on different boards. What truly needs to happen is that we allow for multiple PHYs to be added to otg_transceiver (BTW, that's a mis-naming as transceiver aren't only for OTG use-cases). Anyway, change this phrasing. > > so removes usb_nop_xceiv_register to make musb working. > > > > Cc: Felipe Balbi <balbi@xxxxxx> > > Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx> Considering you change the commit log above: Reviewed-by: Felipe Balbi <balbi@xxxxxx> This is ok, but can only go after 2.6.38 merge window. There are patches to add support for internal PHY. Ideally we would actually register both PHYs and it would work. They would have different capabilities, though. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
