Hi Omar, On Wed, 2010-12-22 at 14:52 -0600, Ramirez Luna, Omar wrote: > Hi Ionut, > > On Thu, Dec 9, 2010 at 3:47 PM, Ionut Nicu <ionut.nicu@xxxxxxxxx> wrote: > > Reorganized some code in the rmgr module to increase > > its readability. No functional changes were done. > > > > Signed-off-by: Ionut Nicu <ionut.nicu@xxxxxxxxxx> > > --- > > drivers/staging/tidspbridge/rmgr/drv.c | 171 +++++++++----------- > > drivers/staging/tidspbridge/rmgr/node.c | 81 +++++----- > > drivers/staging/tidspbridge/rmgr/rmm.c | 266 +++++++++++++----------------- > > 3 files changed, 229 insertions(+), 289 deletions(-) > > > > + > > + /* Update the Driver Object List */ > > + list_add_tail((struct list_head *)pszdev_node, > > + &pdrv_object->dev_node_string); > > I'm not quite comfortable casting to list_head ptr, given that there > is already a member of that type, if the struct type of pszdev_node is > moved around and the first member changes, there should be issues. > > Any reason to use them in this patch? > You are right, it's useless and error prone. I will fix this and the other occurrences. Regards, Ionut. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
