On 12/24/2010 12:08 AM, Grant Likely wrote: > On Wed, Nov 24, 2010 at 04:49:47PM -0800, Kevin Hilman wrote: >> Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> writes: >> >>> As request by Grant Likely, there is no more cover letter. Full changelog is following. >>> I am still reluctant to add this changelog in the patch description, as it adds no value to >>> the patch itself: when it was needed I try to updat comments or patch description. >> >> You're right, the changelog should not be in the patch description. >> This bit of meta-description and changelog should go after the '---' >> just after your signoff. That way, git tools can still auto-apply the >> email, and git ignores stuff after the '---' so it doesn't end up in the >> git history. > > Actually, I used to have the same opinion, but dwmw2 clued me in that > it really is valuable and proper to have the revision history and > changelog in the patch description. When looking back at what > actually got committed into Linus' tree, the changelog gives hints as > to which exact version of the patch got committed (for instance, if a > v6 got merged, but a v7 was also posted that didn't get merged.) > OK if it is the rule for spi subsystem, I will conform to it, and I will add my changelog in the patch description. > BTW, this thread has some discussion about this patch not actually > working correctly. What is the state? Should this version get > merged, or do I need to wait for a v6? Well, I tried to answer to each points to Kevin and to David Brownell. I was waiting for some feedback. I didn't realize it was already near a month ago, so it should be OK. Then I will insert the last comments of Kevin and release the v6. -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
