Re: [PATCH v2] OMAP4: Pandaboard: Fix MMC card detect gpio line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Nishanth Menon <nm@xxxxxx> [101221 06:14]:
> From: Raghuveer Murthy <raghuveer.murthy@xxxxxx>
> 
> commit bf56f0a6668cd (2.6.37-rc1), from Nishanth Menon attempted
> to fix card detection for PandaBoard, unfortunately, the fix missed
> to initialize .gpio_cd member of omap2_hsmmc_info. This results
> in a default value of '0', which is a valid GPIO line.
> On PandaBoard, the side effect of this is that GPIO line 0 controls
> the powering TFP410 DVI chip, and without the fix DVI chip is
> inadvertently powered.
> 
> Tested-by: David Anders <x0132446@xxxxxx>
> 
> Acked-by: Nishanth Menon <nm@xxxxxx>
> 
> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@xxxxxx>
> Signed-off-by: Raghuveer Murthy <raghuveer.murthy@xxxxxx>
> ---
> v2: updated comment description to point out the potential regression.
>    it might be nice to have this in .37 rc cycle as the change was
>    introduced in .37-rc1, however, the DVI functionality(which is impacted
>    as a side effect) is not enabled in .37 rc.

I'll queue this for .38 because of "it never worked earlier either" logic.

Thanks,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux