Re: [PATCH v7 12/12] OMAP2: dmtimer: set wakeup enable explicitly in plat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Cousson, Benoit" <b-cousson@xxxxxx> writes:

> Hi Tarun,
>
> On 12/20/2010 11:05 PM, DebBarma, Tarun Kanti wrote:
>> For some reason the wakeup enable bit is not getting set on OMAP2430,
>> OMAP2420. This is inspite of the fact that SYSC_HAS_ENAWAKEUP flag is
>> present in the hwmod database.
>
> This is indeed strange. Did you observe that on OMAP3 & 4?
> Did you use the patch that Kevin did recently to fix an issue with the
> ENAWAKEUP bit?
> http://git.kernel.org/?p=linux/kernel/git/khilman/linux-omap-pm.git;a=commit;h=d15ae13fc7428a95b02c1935ebf92324fcb80a5f
>
> The point is that this fix is not really acceptable for my point of view:-(
>
> You really have to check what is going on in the hwmod _enable_wakeup
> function.

I completely agree with Benoit.

We cannot merge a fix like this without understanding the root cause.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux