Re: [PATCH v2] ARM: OMAP: Power on EHCI, serial, camera and DVI on beagleboard-xM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Koen Kooi wrote, on 12/19/2010 08:56 AM:

Op 19 dec 2010, om 15:47 heeft Nishanth Menon het volgende geschreven:

Koen Kooi wrote, on 12/19/2010 08:42 AM:
$subject - should'nt you be doing this in separate patches? easier to track with git bisect at a later date than a whole sale change?

Is that really needed?
it is usually recommended to keep each separate functionality introduced/fixed independent of the other.


btw, why are we enabling camera here? should'nt that be done in camera's probe function? no?

On P7/P8 it's the camera, but on A2 and above it's the LDO that powers the TFP410, so if you want to have output on DVI you need to turn it on.
>I'm not sure if it should be part of the DVI init since it has different functions on different board revisions. P7/P8 were not production Beagles if my memory serves me right.. DVI init makes more sense to me.

--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux